Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inconsistent titleBarStyle on transparent fullscreen (2-0-x) #14792

Merged
merged 1 commit into from Sep 25, 2018
Merged

fix: inconsistent titleBarStyle on transparent fullscreen (2-0-x) #14792

merged 1 commit into from Sep 25, 2018

Conversation

codebytere
Copy link
Member

Description of Change

Backport of #14765.
See that commit for details.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: fix inconsistent titleBarStyle on transparent fullscreen

@codebytere codebytere requested a review from a team September 25, 2018 05:24
@codebytere codebytere changed the title fix: inconsistent titleBarStyle on transparent fullscreen fix: inconsistent titleBarStyle on transparent fullscreen (2-0-x) Sep 25, 2018
jkleinsc
jkleinsc approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkleinsc jkleinsc merged commit 503b488 into 2-0-x Sep 25, 2018
@release-clerk
Copy link

release-clerk bot commented Sep 25, 2018

Release Notes Persisted

fix inconsistent titleBarStyle on transparent fullscreen

@jkleinsc jkleinsc deleted the fix-hiddeninset-titlebar-2-0-x branch September 25, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc